Add new datetime field set builder #5944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
reviewed
Dec 21, 2024
| pub fn build_time(mut self) -> Result<TimeFieldSet, BuilderError> { | ||
| let time_field_set = | ||
| TimeFieldSet::T(fieldsets::T::take_from_builder(&mut self, DEFAULT_LENGTH)); | ||
| self.check_options_consumed()?; |
| @@ -236,6 +238,18 @@ macro_rules! impl_marker_with_options { | |||
| $(time_precision: yes_to!(options.time_precision, $timeprecision_yes),)? | |||
| } | |||
| } | |||
| #[allow(unused)] | |||
| pub(crate) fn take_from_builder( | |||
There was a problem hiding this comment.
docs nit: since this is macro generated, docs explaining its behavior would be nice
components/datetime/src/builder.rs
Outdated
| pub year_style: Option<YearStyle>, | ||
| } | ||
|
|
||
| const DEFAULT_LENGTH: Length = Length::Medium; |
There was a problem hiding this comment.
docs nit: should explain why this is here instead of in the macro
|
|
||
| impl FieldSetBuilder { | ||
| pub fn build_date(mut self) -> Result<DateFieldSet, BuilderError> { | ||
| let date_field_set = match self.date_fields.take() { |
There was a problem hiding this comment.
nit: should explain why the time precision is being handled the way it is
|
|
||
| #[derive(Debug, Copy, Clone, PartialEq, Eq, Default)] | ||
| #[non_exhaustive] | ||
| pub struct FieldSetBuilder { |
There was a problem hiding this comment.
docs nit: should have docs explaining use, and talking qualitatively about which combinations are valid. users should ideally not have to use trial and error to figure out what fields they need to set for their use case
sffc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5940